Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 3 May 2022 09:21:49 +0200 | Subject | Re: [PATCH] ARM: dove: fix returnvar.cocci warnings |
| |
On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@intel.com> wrote: > > From: kernel test robot <lkp@intel.com> > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com>
I checked the patch, and unfortunately it is wrong, the current code needs to stay. The problem is the SET_DMA_ERRATA() macro that accesses the local 'errata' variable.
Arnd
| |