lkml.org 
[lkml]   [2022]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/4] MAINTAINERS: Add entries for Apple SoC cpufreq driver
From
On 04/05/2022 16:52, Hector Martin wrote:
> On 04/05/2022 19.17, Viresh Kumar wrote:
>> On 04-05-22, 16:51, Hector Martin wrote:
>>> Splitting this commit, as usual, to facilitate merges via the SoC tree.
>>>
>>> Signed-off-by: Hector Martin <marcan@marcan.st>
>>> ---
>>> MAINTAINERS | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index edc96cdb85e8..39bfa478fe55 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1835,6 +1835,7 @@ T: git https://github.com/AsahiLinux/linux.git
>>> F: Documentation/devicetree/bindings/arm/apple.yaml
>>> F: Documentation/devicetree/bindings/arm/apple/*
>>> F: Documentation/devicetree/bindings/clock/apple,nco.yaml
>>> +F: Documentation/devicetree/bindings/cpufreq/apple,soc-cpufreq.yaml
>>> F: Documentation/devicetree/bindings/i2c/apple,i2c.yaml
>>> F: Documentation/devicetree/bindings/interrupt-controller/apple,*
>>> F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
>>> @@ -1844,6 +1845,7 @@ F: Documentation/devicetree/bindings/power/apple*
>>> F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>>> F: arch/arm64/boot/dts/apple/
>>> F: drivers/clk/clk-apple-nco.c
>>> +F: drivers/cpufreq/apple-soc-cpufreq.c
>>> F: drivers/i2c/busses/i2c-pasemi-core.c
>>> F: drivers/i2c/busses/i2c-pasemi-platform.c
>>> F: drivers/irqchip/irq-apple-aic.c
>>
>> This should be the last patch instead, or should at least be added
>> after the files are merged first. If someone checks out at this
>> commit, the files won't be available but still linked here.
>
> Isn't that backwards?

No, because we have tools for checking valid paths (in some places), so
when using that tool, the history is not bisectable.

> If someone touches the files, we want them to be
> able to get_maintainer.pl, so the MAINTAINERS entries should come first.
> It doesn't really cause any issues if there are entries that point at
> files that don't exist yet, right?

It hurts any current or future tools checking for valid paths.

>
> Though this is mostly a moot point because the purpose of splitting this
> out is so we can merge this one patch through the SoC tree, at which
> point the ordering isn't guaranteed (unless the whole series goes
> through SoC).

Just add each path change to respective commit adding that file. It
should not be a separate commit, at first place.

Separate commits are for adding entire Maintainers entry.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-05-05 10:43    [W:0.081 / U:0.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site