Messages in this thread | | | Date | Wed, 4 May 2022 14:22:44 -0700 (PDT) | From | matthew.gerlach@linux ... | Subject | Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000 |
| |
On Wed, 4 May 2022, Krzysztof Kozlowski wrote:
> On 03/05/2022 21:45, matthew.gerlach@linux.intel.com wrote: >> From: Matthew Gerlach <matthew.gerlach@linux.intel.com> >> >> Add a device tree for the n6000 instantiation of Agilex >> Hard Processor System (HPS). >> >> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > >> + >> + soc { >> + agilex_hps_bridges: bus@80000000 { >> + compatible = "simple-bus"; >> + reg = <0x80000000 0x60000000>, >> + <0xf9000000 0x00100000>; >> + reg-names = "axi_h2f", "axi_h2f_lw"; >> + #address-cells = <0x2>; >> + #size-cells = <0x1>; >> + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>; >> + >> + hps_cp_eng@0 { > > No underscores in node names. dtc W=1 should complain about it.
I will remove the underscores in the name. I didn't see a complaint when I compiled it with "make W=1" in the kernel tree.
> The node name should be generic, matching class of a device. What is > this exactly?
The component is a specialized IP block instantiated in the FPGA directly connected to the HPS. In one sense the IP block is a simple DMA controller, but it also has some registers for hand shaking between the HPS and a host processor connected to the FPGA via PCIe. Should I call the node, dma@0?
Thanks for your review, Matthew
> > Best regards, > Krzysztof >
| |