lkml.org 
[lkml]   [2022]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000
    From
    On 03/05/2022 21:45, matthew.gerlach@linux.intel.com wrote:
    > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
    >
    > Add a device tree for the n6000 instantiation of Agilex
    > Hard Processor System (HPS).
    >
    > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
    > +
    > +&spi0 {
    > + status = "okay";
    > +
    > + spidev: spidev@0 {
    > + status = "okay";
    > + compatible = "linux,spidev";
    > + spi-max-frequency = <25000000>;
    > + reg = <0>;

    You should see big fat warnings - from checkpatch and when you boot your
    device. This compatible is not accepted.

    Please be sure you run checkpatch on your patches. Using reviewers time
    instead of automated tool for the same job is discouraged...


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-05-04 16:58    [W:2.671 / U:0.856 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site