Messages in this thread Patch in this message | | | Date | Sun, 29 May 2022 19:25:54 +0200 | From | Nam Cao <> | Subject | [PATCH] dmaengine: altera-msgdma: correct mutex locking order |
| |
The order of spin_unlock and spin_lock seems wrong. Correct it.
Signed-off-by: Nam Cao <namcaov@gmail.com> --- drivers/dma/altera-msgdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c index 6f56dfd375e3..e35096c12abc 100644 --- a/drivers/dma/altera-msgdma.c +++ b/drivers/dma/altera-msgdma.c @@ -591,9 +591,9 @@ static void msgdma_chan_desc_cleanup(struct msgdma_device *mdev) dmaengine_desc_get_callback(&desc->async_tx, &cb); if (dmaengine_desc_callback_valid(&cb)) { - spin_unlock(&mdev->lock); - dmaengine_desc_callback_invoke(&cb, NULL); spin_lock(&mdev->lock); + dmaengine_desc_callback_invoke(&cb, NULL); + spin_unlock(&mdev->lock); } /* Run any dependencies, then free the descriptor */ -- 2.25.1
| |