Messages in this thread | | | Date | Fri, 27 May 2022 08:22:41 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 21/31] soc/tegra: Remove the call to devm_pm_opp_set_clkname() |
| |
On 26-05-22, 20:57, Dmitry Osipenko wrote: > On 5/26/22 14:42, Viresh Kumar wrote: > > The OPP core already performs devm_pm_opp_set_clkname() with name as > > NULL, the callers shouldn't be doing the same unless they have a > > different clock name to add here.
This is confusing. Updated this as:
The OPP core already performs clk_get(dev, NULL) by default for everyone and the callers shouldn't try to set clkname unless they have an actual clock name to add here.
> > > > Drop the call. > > > > Cc: Dmitry Osipenko <digetx@gmail.com> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > drivers/soc/tegra/common.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c > > index 32c346b72635..49a5360f4507 100644 > > --- a/drivers/soc/tegra/common.c > > +++ b/drivers/soc/tegra/common.c > > @@ -108,12 +108,6 @@ int devm_tegra_core_dev_init_opp_table(struct device *dev, > > u32 hw_version; > > int err; > > > > - err = devm_pm_opp_set_clkname(dev, NULL); > > - if (err) { > > - dev_err(dev, "failed to set OPP clk: %d\n", err); > > - return err; > > - } > > - > > /* Tegra114+ doesn't support OPP yet */ > > if (!of_machine_is_compatible("nvidia,tegra20") && > > !of_machine_is_compatible("nvidia,tegra30")) > > I can't see where OPP core performs devm_pm_opp_set_clkname().
Sorry about that, it is clk_get() it performs from _update_opp_table_clk().
I don't think you need to call devm_pm_opp_set_clkname() here, but lets see if this breaks anything for you.
-- viresh
| |