lkml.org 
[lkml]   [2022]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm/hugetlb: Remove unnecessary huge_ptep_set_access_flags() in hugetlb_mcopy_atomic_pte()
From


On 5/26/2022 3:01 PM, Anshuman Khandual wrote:
>
>
> On 5/25/22 15:56, Baolin Wang wrote:
>> There is no need to update the hugetlb access flags after just setting the
>> hugetlb page table entry by set_huge_pte_at(), since the page table entry
>> value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags()
>
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #9:
> value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags()
>
> total: 0 errors, 1 warnings, 8 lines checked

Sure, will remove checkpatch warning in next verion.

>
>> in hugetlb_mcopy_atomic_pte().
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>
> Otherwise LGTM,
>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

Thanks. Also thanks to Muchun and Mike for reviewing.

\
 
 \ /
  Last update: 2022-05-27 03:35    [W:0.069 / U:1.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site