lkml.org 
[lkml]   [2022]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC v2 0/2] Add support for multiport controller
Date
Currently the DWC3 driver supports only single port controller which 
requires at most two PHYs ie HS and SS PHYs. There are SoCs that has
DWC3 controller with multiple ports that can operate in host mode. Some of
the port supports both SS+HS and other port supports only HS mode.

This change refactors the PHY logic to support multiport controller. The
patches have gone through basic sanity only.

For any multiport controller we would define a new node "multiport" inside
dwc3 and then add subsequent "mport" nodes inside it for individual ports
that it supports. Now each individual "mport" defines the PHYs that it
supports.

Looking for comments/feedback on the device tree bindings. Once the
bindings are locked, we can further factor the code.

e.g.
Consider a Dual port controller where each port supports HS+SS

multiport {
mp_1: mport@1 {
usb-phy = <usb2_phy0>, <usb3_phy0>;
/* Can define Generic PHYs also */
};
mp_2: mport@2 {
usb-phy = <usb2_phy1>, <usb3_phy1>;
};

Changes in v2:
Added support for Generic PHYs by making use of devm_of_phy_get. It works
for both normal controller and multiport controller.
Cleaned up dwc3_core_get_phy and created new API dwc3_core_get_phy_by_node
which works for both normal and multiport node case.
Addded new APIs to count PHYs defined in the multiport controller.
Changed Generic PHY to double pointer to work for multiport controller.
Added support for GUSB2PHYCFG and GUSB3PIPECTL registers
for multiport controller.


Harsh Agarwal (2):
dt-bindings: usb: dwc3: Add support for multiport related properties
usb: dwc3: Refactor PHY logic to support Multiport Controller

.../devicetree/bindings/usb/snps,dwc3.yaml | 55 +++
drivers/usb/dwc3/core.c | 420 +++++++++++++++------
drivers/usb/dwc3/core.h | 12 +-
drivers/usb/dwc3/drd.c | 16 +-
drivers/usb/dwc3/gadget.c | 4 +-
5 files changed, 381 insertions(+), 126 deletions(-)

--
2.7.4

\
 
 \ /
  Last update: 2022-05-26 12:15    [W:1.020 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site