lkml.org 
[lkml]   [2022]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectdrivers/dma-buf/st-dma-fence-unwrap.c:125:13: warning: variable 'err' set but not used
Hi Christian,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fdaf9a5840acaab18694a19e0eb0aa51162eeeed
commit: 64a8f92fd783e750cdb81af75942dcd53bbf61bd dma-buf: add dma_fence_unwrap v2
date: 9 weeks ago
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220525/202205252017.OlDscDi2-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=64a8f92fd783e750cdb81af75942dcd53bbf61bd
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 64a8f92fd783e750cdb81af75942dcd53bbf61bd
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/dma-buf/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/dma-buf/st-dma-fence-unwrap.c: In function 'unwrap_array':
>> drivers/dma-buf/st-dma-fence-unwrap.c:125:13: warning: variable 'err' set but not used [-Wunused-but-set-variable]
125 | int err = 0;
| ^~~
drivers/dma-buf/st-dma-fence-unwrap.c: In function 'unwrap_chain':
drivers/dma-buf/st-dma-fence-unwrap.c:167:13: warning: variable 'err' set but not used [-Wunused-but-set-variable]
167 | int err = 0;
| ^~~
drivers/dma-buf/st-dma-fence-unwrap.c: In function 'unwrap_chain_array':
drivers/dma-buf/st-dma-fence-unwrap.c:209:13: warning: variable 'err' set but not used [-Wunused-but-set-variable]
209 | int err = 0;
| ^~~


vim +/err +125 drivers/dma-buf/st-dma-fence-unwrap.c

120
121 static int unwrap_array(void *arg)
122 {
123 struct dma_fence *fence, *f1, *f2, *array;
124 struct dma_fence_unwrap iter;
> 125 int err = 0;
126
127 f1 = mock_fence();
128 if (!f1)
129 return -ENOMEM;
130
131 f2 = mock_fence();
132 if (!f2) {
133 dma_fence_put(f1);
134 return -ENOMEM;
135 }
136
137 array = mock_array(2, f1, f2);
138 if (!array)
139 return -ENOMEM;
140
141 dma_fence_unwrap_for_each(fence, &iter, array) {
142 if (fence == f1) {
143 f1 = NULL;
144 } else if (fence == f2) {
145 f2 = NULL;
146 } else {
147 pr_err("Unexpected fence!\n");
148 err = -EINVAL;
149 }
150 }
151
152 if (f1 || f2) {
153 pr_err("Not all fences seen!\n");
154 err = -EINVAL;
155 }
156
157 dma_fence_signal(f1);
158 dma_fence_signal(f2);
159 dma_fence_put(array);
160 return 0;
161 }
162

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-05-25 15:01    [W:0.027 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site