| Date | Tue, 24 May 2022 17:27:25 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 08/16] ptrace: Only populate last_siginfo from ptrace |
| |
On 05/18, Eric W. Biederman wrote: > > The code in ptrace_signal to populate siginfo if the signal number > changed is buggy. If the tracer contined the tracee using > ptrace_detach it is guaranteed to use the real_parent (or possibly a > new tracer) but definitely not the origional tracer to populate si_pid > and si_uid.
I guess nobody cares. As the comment says
If the debugger wanted something specific in the siginfo structure then it should have updated *info via PTRACE_SETSIGINFO.
otherwise I don't think si_pid/si_uid have any value.
However the patch looks fine to me, just the word "buggy" looks a bit too strong imo.
Oleg.
|