lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 03/16] kdb: Use real_parent when displaying a list of processes
    kdb has a bug that when using the ps command to display a list of
    processes, if a process is being debugged the debugger as the parent
    process.

    This is silly, and I expect it never comes up in ptractice. As there
    is very little point in using gdb and kdb simultaneously. Update the
    code to use real_parent so that it is clear kdb does not want to
    display a debugger as the parent of a process.

    Cc: Jason Wessel <jason.wessel@windriver.com>
    Cc: Daniel Thompson <daniel.thompson@linaro.org>
    Cc: Douglas Anderson <dianders@chromium.org>
    Fixes: 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)"
    Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    ---
    kernel/debug/kdb/kdb_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
    index 0852a537dad4..db49f1026eaa 100644
    --- a/kernel/debug/kdb/kdb_main.c
    +++ b/kernel/debug/kdb/kdb_main.c
    @@ -2306,7 +2306,7 @@ void kdb_ps1(const struct task_struct *p)

    cpu = kdb_process_cpu(p);
    kdb_printf("0x%px %8d %8d %d %4d %c 0x%px %c%s\n",
    - (void *)p, p->pid, p->parent->pid,
    + (void *)p, p->pid, p->real_parent->pid,
    kdb_task_has_cpu(p), kdb_process_cpu(p),
    kdb_task_state_char(p),
    (void *)(&p->thread),
    --
    2.35.3
    \
     
     \ /
      Last update: 2022-05-19 00:55    [W:2.645 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site