Messages in this thread | | | Date | Mon, 23 May 2022 14:27:15 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v1] spi: imx: mx51-ecspi: fix clk polarity and phase configuration for CS > 4 |
| |
On Mon, May 23, 2022 at 09:31:43AM +0200, Oleksij Rempel wrote:
> - /* set chip select to use */ > - ctrl |= MX51_ECSPI_CTRL_CS(spi->chip_select); > + if (spi->cs_gpiod) { > + chip_select = 0;
What if someone mixed GPIO and regular chip selects and 0 is one of the in use chip selects? Ideally we should check for an unused chip select here, though the current change is still an improvement since we'll at least only write in the chip select field. [unhandled content-type:application/pgp-signature] | |