Messages in this thread | ![/](/images/icornerl.gif) | | From | Corentin Labbe <> | Subject | [PATCH v3 0/3] arm64: add ethernet to orange pi 3 | Date | Mon, 23 May 2022 05:28:04 +0000 |
| |
Hello
2 sunxi board still does not have ethernet working, orangepi 1+ and orangepi 3. This is due to the fact thoses boards have a PHY which need 2 regulators.
A first attempt by Ondřej Jirman was made to support them was made by adding support in stmmac driver: https://lore.kernel.org/lkml/20190820145343.29108-6-megous@megous.com/ Proposal rejected, since regulators need to be handled by the PHY core.
My first tentative was to just add handling of phy and phy-io in phy-core: https://lore.kernel.org/netdev/20220509074857.195302-7-clabbe@baylibre.com/T/ But having hard-coded phy names was rejected.
Second tentative tryed the same path than clocks and clock-names for regulators. https://lore.kernel.org/netdev/0518eef1-75a6-fbfe-96d8-bb1fc4e5178a@linaro.org/t/ But using this was rejected by DT maintainers.
So v3 use a new regulator_bulk_get_all() which grab all supplies properties in a DT node. But this way could have some problem, a netdev driver could handle already its PHY (like dwmac-sun8i already do) and so both phy-core and the netdev will use both. It is why phy-supply was renamed in ephy-supply in patch #3.
This serie was tested on whole range of board and PHY architecture: - internal PHY * sun8i-h3-orangepi-pc - external PHY * sun50i-h6-pine-h64 * sun8i-r40-bananapi-m2-ultra * sun8i-a83t-bananapi-m3 * sun50i-a64-bananapi-m64 * sun50i-h6-orangepi-3 * sun50i-h5-nanopi-neo-plus2
The resume/suspend of PHY was tested.
Regards
changes since v1: - Add regulator_bulk_get_all for ease handling of PHY regulators - Removed all convertion patchs to keep DT compatibility.
Changes since v2: - removed use of regulator-names and regulators list.
Corentin Labbe (2): regulator: Add regulator_bulk_get_all phy: handle optional regulator for PHY
Ondřej Jirman (1): arm64: dts: allwinner: orange-pi-3: Enable ethernet
.../dts/allwinner/sun50i-h6-orangepi-3.dts | 38 ++++++++ drivers/net/mdio/Kconfig | 1 + drivers/net/mdio/fwnode_mdio.c | 36 +++++++- drivers/net/phy/phy_device.c | 10 ++ drivers/regulator/core.c | 92 +++++++++++++++++++ include/linux/phy.h | 3 + include/linux/regulator/consumer.h | 2 + 7 files changed, 178 insertions(+), 4 deletions(-)
-- 2.35.1
| ![\](/images/icornerr.gif) |