lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 1/9] tty: n_gsm: fix user open not possible at responder until initiator open
Date
> > +/**
> > + * gsm_dlci_wait_open - wait for channel open procedure
> > + * @dlci: DLCI to open
> > + *
> > + * Wait for a DLCI opening from the other side. Asynchronously wait until
> > + * we get a SABM and set off timers and the responses.
> > + */
> > +static void gsm_dlci_wait_open(struct gsm_dlci *dlci) {
> > + switch (dlci->state) {
> > + case DLCI_CLOSED:
> > + case DLCI_CLOSING:
> > + dlci->state = DLCI_OPENING;
> > + break;
> > + default:
> > + break;
> > + }
> > +}
>
> The documentation for this function is odd, you are not waiting for
> anything. You are just changing the state. This makes no sense as-is,
> sorry.

Thank you for your comment. I have prepared a new version. I will send it
after the other 8 patches have been commented.

Best regards,
Daniel Starke

\
 
 \ /
  Last update: 2022-05-23 10:46    [W:4.378 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site