Messages in this thread | | | Date | Sat, 21 May 2022 23:26:55 +0300 | Subject | Re: [PATCH v3] staging: r8188eu: add check for kzalloc | From | Pavel Skripkin <> |
| |
Hi Martin,
On 5/21/22 18:50, Martin Kaiser wrote: > >> for (i = 0; i < 4; i++) >> @@ -1474,7 +1479,7 @@ s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) > > > res is still 0 here - but the caller of _rtw_init_xmit_priv compares > this return value with _SUCCESS (1) or _FAIL (0) and interprets it as > _FAIL. >
I think, it's time to make
s/_SUCCESS/0/ s/_FAIL/-1
since developers from outside of staging are confused. The main problem will be with functions that return an int (or s32).
Will take a look.
With regards, Pavel Skripkin
| |