Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 19 May 2022 14:01:28 +0200 | Subject | Re: [PATCH v4 6/7] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Document the properties to handle GPIO IRQ |
| |
Hi Prabhakar,
On Wed, May 18, 2022 at 9:30 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Document the required properties to handle GPIO IRQ. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml > @@ -126,6 +139,9 @@ examples: > gpio-controller; > #gpio-cells = <2>; > gpio-ranges = <&pinctrl 0 0 392>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupt-parent = <&irqc>;
I think the "interrupt-parent" property can be dropped from the example.
> clocks = <&cpg CPG_MOD R9A07G044_GPIO_HCLK>; > resets = <&cpg R9A07G044_GPIO_RSTN>, > <&cpg R9A07G044_GPIO_PORT_RESETN>,
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |