Messages in this thread Patch in this message | | | From | Tom Rix <> | Subject | [PATCH] misc: rtsx: Set setting_reg2 before use. | Date | Mon, 16 May 2022 09:00:47 -0400 |
| |
The clang build fails with rts5261.c:406:13: error: variable 'setting_reg2' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] } else if (efuse_valid == 0) { ^~~~~~~~~~~~~~~~
setting_reg2 is set in this block if (efuse_valid == 2 || efuse_valid == 3) { .. } else if (efuse_valid == 0) { // default .. } But efuse_valid can also have a value of 1. Change the 'else if' to 'else' to make the second block the default.
Fixes: b1c5f3085149 ("misc: rtsx: add rts5261 efuse function") Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/misc/cardreader/rts5261.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c index 749cc5a46d13..f22634b14dc8 100644 --- a/drivers/misc/cardreader/rts5261.c +++ b/drivers/misc/cardreader/rts5261.c @@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr) setting_reg1 = PCR_SETTING_REG4; setting_reg2 = PCR_SETTING_REG5; } - } else if (efuse_valid == 0) { + } else { // default setting_reg1 = PCR_SETTING_REG1; setting_reg2 = PCR_SETTING_REG2; -- 2.27.0
| |