lkml.org 
[lkml]   [2022]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] random: move initialization out of reseeding hot path
Hi Dominik,

On Fri, May 13, 2022 at 08:24:19AM +0200, Dominik Brodowski wrote:
> > - if (!crng_ready()) {
> > - crng_init = CRNG_READY;
> > - finalize_init = true;
> > - }
> > + crng_init = CRNG_READY;
>
> Why unconditionally

To avoid a useless branch.


> (you revert that bit in the static branch patch and make
> it conditional again; so I see no reason for that here)?

With the static branch patch, I can totally remove the branch and the
store all together, so we get the best of both worlds.

Jason

\
 
 \ /
  Last update: 2022-05-13 12:22    [W:0.075 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site