Messages in this thread | | | From | "Jason A. Donenfeld" <> | Date | Fri, 13 May 2022 14:02:39 +0200 | Subject | Re: [PATCH 2/2] random: move initialization out of reseeding hot path |
| |
Hi David,
On Fri, May 13, 2022 at 1:38 PM David Laight <David.Laight@aculab.com> wrote: > > From: Jason A. Donenfeld > > Sent: 13 May 2022 11:22 > > > > On Fri, May 13, 2022 at 08:24:19AM +0200, Dominik Brodowski wrote: > > > > - if (!crng_ready()) { > > > > - crng_init = CRNG_READY; > > > > - finalize_init = true; > > > > - } > > > > + crng_init = CRNG_READY; > > > > > > Why unconditionally > > > > To avoid a useless branch. > > Are you now dirtying a cache line that would > otherwise be clean?
Fair enough. I'll keep the branch.
Jason
| |