Messages in this thread | | | From | Stephen Boyd <> | Date | Tue, 10 May 2022 10:49:11 -0700 | Subject | Re: [PATCH v4 3/5] arm64: dts: qcom: sc7180: Add quackingstick dts files |
| |
Quoting Joseph S. Barrera III (2022-05-05 10:41:14) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi > new file mode 100644 > index 000000000000..e0c0ab748ca7 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi > @@ -0,0 +1,324 @@ [...] > + > +&camcc { > + status = "okay"; > +}; > + > +&dsi0 { > +
Nitpick: Drop newline here
> + panel: panel@0 {
Please add the same comment here.
> + reg = <0>; > + enable-gpios = <&tlmm 87 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_rst>; > + avdd-supply = <&ppvar_lcd>; > + pp1800-supply = <&v1p8_disp>; > + pp3300-supply = <&pp3300_dx_edp>; > + backlight = <&backlight>; > + rotation = <270>; > +
| |