Messages in this thread | | | From | Stephen Boyd <> | Date | Tue, 10 May 2022 10:40:48 -0700 | Subject | Re: [PATCH v4 1/5] arm64: dts: qcom: sc7180: Add wormdingler dts files |
| |
Quoting Joseph S. Barrera III (2022-05-05 10:41:12) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi > new file mode 100644 > index 000000000000..e947e01d0b3b > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi > @@ -0,0 +1,417 @@ [...] > + > +/* PINCTRL - board-specific pinctrl */ > + > +&tlmm { > + gpio-line-names = "HUB_RST_L", [...] > + > + vdd_reset_1800: vdd-reset-1800 { > + pinmux { > + pins = "gpio87"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio87"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > + > + avdd_lcd_en: avdd-lcd-en { > + pinmux { > + pins = "gpio88"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio88"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > + > + avee_lcd_en: avee-lcd_en {
avee-lcd-en
No underscores in node names please.
> + pinmux { > + pins = "gpio21"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio21"; > + drive-strength = <2>; > + bias-disable; > + }; > + };
Are these supposed to be sorted by node name? Or gpio number? Please do one of those.
> + > + mipi_1800_en: mipi-1800-en { > + pinmux { > + pins = "gpio86"; > + function = "gpio"; > + }; > + > + pinconf { > + pins = "gpio86"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > +};
| |