| Date | Sat, 9 Apr 2022 13:07:00 +0200 | Subject | Re: [PATCH 01/18] MIPS: DTS: jz4780: remove cpu clock-names as reported by dtbscheck | From | Krzysztof Kozlowski <> |
| |
On 08/04/2022 20:37, H. Nikolaus Schaller wrote: > arch/mips/boot/dts/ingenic/ci20.dtb: cpu@0: clock-names does not match any of the regexes: pinctrl-[0-9]+ > From schema: Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: cpu@1: clock-names does not match any of the regexes: pinctrl-[0-9]+ > From schema: Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
No need to put the same warning twice (cpu index really does not matter). One warning is enough.
Fixing warnings is good, but what if the property should be there and the bindings are not correct? If you know the answer, please add it to the commit msg.
This applies to all your patches. Blind fixing of DTS warnings my produce incorrect results. :(
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
|