lkml.org 
[lkml]   [2022]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 18/18] MIPS: DTS: CI20: fix bluetooth as reported by dtbscheck
From
Date


> Am 09.04.2022 um 13:22 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>:
>
> On 08/04/2022 20:38, H. Nikolaus Schaller wrote:
>> arch/mips/boot/dts/ingenic/ci20.dtb: bluetooth: vcc-supply does not match any of the regexes: pinctrl-[0-9]+
>> From schema: Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
>> index dc587b4b36009..8a120f9374331 100644
>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>> @@ -207,7 +207,7 @@ &uart2 {
>> bluetooth {
>> compatible = "brcm,bcm4330-bt";
>> reset-gpios = <&gpf 8 GPIO_ACTIVE_HIGH>;
>> - vcc-supply = <&wlan0_power>;
>> + vbat-supply = <&wlan0_power>;
>
> Could be also vddio...

Good hint.

Schematics has both vbat AND vddio connected.

But with that finding, there is also a wifi_io regulator
for 2.5V. It is always-on and NOT yet controlled.

So this is worth a functional addition. But not related
to dtbscheck cleanup because it even is optional.
Hence a separate topic.

>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> Best regards,
> Krzysztof

In summary for reviewing all patches: many thanks!

BR,
Nikolaus
\
 
 \ /
  Last update: 2022-04-09 15:12    [W:0.101 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site