lkml.org 
[lkml]   [2022]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 6/6] pmem: implement pmem_recovery_write()
On Tue, Apr 05, 2022 at 01:47:47PM -0600, Jane Chu wrote:
> + off = (unsigned long)addr & ~PAGE_MASK;

offset_inpage()

> + if (off || !(PAGE_ALIGNED(bytes))) {

No need for the inner braces.

> + mutex_lock(&pmem->recovery_lock);
> + pmem_off = PFN_PHYS(pgoff) + pmem->data_offset;
> + cleared = __pmem_clear_poison(pmem, pmem_off, len);
> + if (cleared > 0 && cleared < len) {
> + dev_warn(dev, "poison cleared only %ld out of %lu\n",
> + cleared, len);
> + mutex_unlock(&pmem->recovery_lock);
> + return 0;
> + } else if (cleared < 0) {

No need for an else after a return.

\
 
 \ /
  Last update: 2022-04-06 09:04    [W:0.492 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site