lkml.org 
[lkml]   [2022]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v7 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops
    Date
    On 4/11/2022 10:02 PM, Christoph Hellwig wrote:
    > On Mon, Apr 11, 2022 at 09:57:36PM -0700, Dan Williams wrote:
    >> So how about change 'int flags' to 'enum dax_access_mode mode' where
    >> dax_access_mode is:
    >>
    >> /**
    >> * enum dax_access_mode - operational mode for dax_direct_access()
    >> * @DAX_ACCESS: nominal access, fail / trim access on encountering poison
    >> * @DAX_RECOVERY_WRITE: ignore poison and provide a pointer suitable
    >> for use with dax_recovery_write()
    >> */
    >> enum dax_access_mode {
    >> DAX_ACCESS,
    >> DAX_RECOVERY_WRITE,
    >> };
    >>
    >> Then the conversions look like this:
    >>
    >> - rc = dax_direct_access(iter->iomap.dax_dev, pgoff, 1, &kaddr, NULL);
    >> + rc = dax_direct_access(iter->iomap.dax_dev, pgoff, 1,
    >> DAX_ACCESS, &kaddr, NULL);
    >>
    >> ...and there's less chance of confusion with the @nr_pages argument.
    >
    > Yes, this might be a little nicer.

    Will do.

    Thanks!
    -jane

    \
     
     \ /
      Last update: 2022-04-14 02:53    [W:2.362 / U:0.940 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site