| Date | Tue, 5 Apr 2022 10:05:59 -0700 | Subject | Re: [PATCH V3 17/30] x86/sgx: Support modifying SGX page type | From | Reinette Chatre <> |
| |
Hi Jarkko,
On 4/5/2022 8:34 AM, Jarkko Sakkinen wrote: > On Tue, 2022-04-05 at 10:06 +0300, Jarkko Sakkinen wrote:
>>> >> >> To be coherent with other names, this should be >> SGX_IOC_ENCLAVE_MODIFY_TYPES.
This is not such a clear change request to me:
SGX_IOC_ENCLAVE_ADD_PAGES - add multiple pages SGX_IOC_ENCLAVE_RESTRICT_PERMISSIONS - restrict multiple permissions SGX_IOC_ENCLAVE_REMOVE_PAGES - remove multiple pages SGX_IOC_ENCLAVE_MODIFY_TYPE - set a single type
Perhaps it should rather be SGX_IOC_ENCLAVE_SET_TYPE to indicate that there is a single target type as opposed to the possibility of multiple source types (TCS and regular pages can be trimmed).
> > This should take only page type given that flags are zeroed: > > EPCM(DS:RCX).R := 0; > EPCM(DS:RCX).W := 0; > EPCM(DS:RCX).X := 0; >
ok, this was how it was done in V1 [1] and I can go back to that.
Reinette
[1] https://lore.kernel.org/linux-sgx/c0f04a8f7e1afd9e9319bb9f283db9a3187f7abc.1638381245.git.reinette.chatre@intel.com/
|