Messages in this thread | | | Subject | Re: [PATCH] net: ax88179: add proper error handling of usb read errors | From | Paolo Abeni <> | Date | Tue, 05 Apr 2022 11:44:50 +0200 |
| |
On Mon, 2022-04-04 at 18:10 +0300, David Kahurani wrote: > @@ -354,8 +369,15 @@ static int ax88179_mdio_read(struct net_device *netdev, int phy_id, int loc) > { > struct usbnet *dev = netdev_priv(netdev); > u16 res; > + int ret; > + > + ret = ax88179_read_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res); > + > + if (ret < 0){
For the records: another recurring indentation issue is the lack of a whitespace after the ')'.
Please address all the issues reported by scritps/checkpatch.pl before submitting the next version, thanks!
Paolo
| |