Messages in this thread | | | Date | Thu, 14 Apr 2022 09:31:56 +0200 | Subject | Re: [PATCH] net: ax88179: add proper error handling of usb read errors | From | Oliver Neukum <> |
| |
On 13.04.22 17:32, Dan Carpenter wrote: > > Bug: buffer partially filled. Information leak. > > If you return the bytes then the only correct way to write error > handling is: > > if (ret < 0) > return ret; > if (ret != size) > return -EIO; > You have to make up your mind on whether you ever need to read answer of a length not known before you try it. The alternative of passing a pointer to an integer for length is worse.
Regards Oliver
| |