Messages in this thread | | | Date | Wed, 27 Apr 2022 18:49:42 +0900 | From | Jung Daehwan <> | Subject | Re: [PATCH v4 0/5] add xhci-exynos driver |
| |
On Tue, Apr 26, 2022 at 02:46:14PM +0200, Krzysztof Kozlowski wrote: > On 26/04/2022 11:18, Daehwan Jung wrote: > > This patchset is for Samsung Exynos xhci host conroller. It uses xhci-plat > > driver mainly and extends some functions by xhci hooks and overrides. > > > > This driver supports USB offload which makes Co-processor to use > > some memories of xhci. Especially it's useful for USB Audio scenario. > > Audio stream would get shortcut because Co-processor directly write/read > > data in xhci memories. It could get speed-up using faster memory like SRAM. > > That's why this gives vendors flexibilty of memory management. This feature > > is done with xhci hooks and overrides. > > > > Changes in v2 : > > - Fix commit message by adding Signed-off-by in each patch. > > - Fix conflict on latest. > > > > Changes in v3 : > > - Remove export symbols and xhci hooks which xhci-exynos don't need. > > - Modify commit message to clarify why it needs to export symbols. > > - Check compiling of xhci-exynos. > > > > Changes in v4 : > > - Modify commit message to clarify why it needs to export symbols. > > - Add a function for override of hc driver in xhci-plat. > > - Make xhci-exynos extending xhci-plat by xhci hooks and overrides. > > (vendor_init / vendor_cleanup hooks are useful from here v4) > > - Change the term (USB offload -> xhci-exynos) on subject of patches. > > > > You received comments already that you need to base your work on recent > Linux kernel and use scripts/get_maintainers.pl to notify necessary > parties. This is the fourth patchset and still you did not do it. > > Maybe there is some misunderstanding or trouble using > scripts/get_maintainers.pl, so could you clarify: > > 1. What is this based on? Output of: git describe
url = https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next fetch = +refs/heads/*:refs/remotes/origin/*
or
url = https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git fetch = +refs/heads/*:refs/remotes/origin/*
> > 2. What does the scripts/get_maintainers.pl print when you run on this > patchset?
I don't see your name in xhci even for whole usb/host directory. I see same result on above 2 gits.
jdh@PlatFormDev3:~/works/mainline/linux-next$ ./scripts/get_maintainer.pl drivers/usb/host/ Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM,commit_signer:170/184=92%) Mathias Nyman <mathias.nyman@linux.intel.com> (commit_signer:52/184=28%,authored:25/184=14%) Alan Stern <stern@rowland.harvard.edu> (commit_signer:30/184=16%) Chunfeng Yun <chunfeng.yun@mediatek.com> (commit_signer:23/184=12%,authored:21/184=11%) linux-usb@vger.kernel.org (open list:USB SUBSYSTEM) linux-kernel@vger.kernel.org (open list)
>
In fact, I manually tried adding you as you commendted previous patchset. But, It seems you changed email id and domain..
Best Regards, Jung Daehwan
> > Best regards, > Krzysztof >
| |