Messages in this thread | | | Date | Thu, 28 Apr 2022 12:26:10 +0900 | From | Jung Daehwan <> | Subject | Re: [PATCH v4 5/5] usb: host: add xhci-exynos driver |
| |
On Tue, Apr 26, 2022 at 12:20:56PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 26, 2022 at 06:18:48PM +0900, Daehwan Jung wrote: > > This driver is for Samsung Exynos xhci host conroller. It uses xhci-plat > > driver mainly and extends some functions by xhci hooks and overrides. > > > > It supports USB Audio offload with Co-processor. It only cares DCBAA, > > Device Context, Transfer Ring, Event Ring, and ERST. They are allocated > > on specific address with xhci hooks. Co-processor could use them directly > > without xhci driver after then. > > > > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com> > > --- > > drivers/usb/host/Kconfig | 8 + > > drivers/usb/host/Makefile | 1 + > > drivers/usb/host/xhci-exynos.c | 567 +++++++++++++++++++++++++++++++++ > > drivers/usb/host/xhci-exynos.h | 50 +++ > > Why do you need a .h file for a simple single driver like this? Just > put it all into the .c file please. > > thanks, > > greg k-h >
Yes. I will do it on next submission.
Best Regards, Jung Daehwan
| |