Messages in this thread | | | Date | Tue, 26 Apr 2022 14:12:38 +0200 | From | Greg KH <> | Subject | Re: [PATCH] tty: n_gsm: return -EINVAL when adaption is not supported |
| |
On Tue, Apr 26, 2022 at 08:05:54AM -0400, Tom Rix wrote: > The clang build fails with > n_gsm.c:940:13: error: variable 'size' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > } else if (dlci->adaption == 2) { > ^~~~~~~~~~~~~~~~~~~ > > The else should return an error, so return -EINVAL. > > Signed-off-by: Tom Rix <trix@redhat.com>
What commit id does this fix? Any reason you didn't cc: the author of the recent changes to this code?
Is this the same issue that 0-day reported?
thanks,
greg k-h
| |