lkml.org 
[lkml]   [2022]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tty: n_gsm: return -EINVAL when adaption is not supported
From
Date

On 4/26/22 5:12 AM, Greg KH wrote:
> On Tue, Apr 26, 2022 at 08:05:54AM -0400, Tom Rix wrote:
>> The clang build fails with
>> n_gsm.c:940:13: error: variable 'size' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>> } else if (dlci->adaption == 2) {
>> ^~~~~~~~~~~~~~~~~~~
>>
>> The else should return an error, so return -EINVAL.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
> What commit id does this fix? Any reason you didn't cc: the author of
> the recent changes to this code?
Sorry missed this part.
> Is this the same issue that 0-day reported?

Maybe, it was part of next's update today.  Where is 0-day reported ?

Tom

>
> thanks,
>
> greg k-h
>

\
 
 \ /
  Last update: 2022-04-26 20:18    [W:0.648 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site