Messages in this thread | | | Date | Mon, 25 Apr 2022 15:54:00 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 0/8] stackleak: fixes and rework |
| |
On Mon, Apr 25, 2022 at 12:55:55PM +0100, Mark Rutland wrote: > This series reworks the stackleak code. The first patch fixes some > latent issues on arm64, and the subsequent patches improve the code to > improve clarity and permit better code generation.
This looks nice; thanks! I'll put this through build testing and get it applied shortly...
> While the improvement is small, I think the improvement to clarity and > code generation is a win regardless.
Agreed. I also want to manually inspect the resulting memory just to make sure things didn't accidentally regress. There's also an LKDTM test for basic functionality.
-Kees
-- Kees Cook
| |