Messages in this thread | | | Date | Tue, 26 Apr 2022 17:07:08 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH 0/8] stackleak: fixes and rework |
| |
On Tue, Apr 26, 2022 at 06:51:04PM +0300, Alexander Popov wrote: > On 26.04.2022 01:54, Kees Cook wrote: > > On Mon, Apr 25, 2022 at 12:55:55PM +0100, Mark Rutland wrote: > > > This series reworks the stackleak code. The first patch fixes some > > > latent issues on arm64, and the subsequent patches improve the code to > > > improve clarity and permit better code generation. > > > > This looks nice; thanks! I'll put this through build testing and get it > > applied shortly... > > > > > While the improvement is small, I think the improvement to clarity and > > > code generation is a win regardless. > > > > Agreed. I also want to manually inspect the resulting memory just to > > make sure things didn't accidentally regress. There's also an LKDTM test > > for basic functionality. > > Hi Mark and Kees! > > Glad to see this patch series. > > I've looked at it briefly. Mark, I see your questions in the patches that I > can answer. > > Please give me some time, I'm going to work on your patch series next week. > I'll return with review and testing.
Sure thing, thanks!
FWIW, I spotted a couple of issues in my patches today while testing, and if you're happy I can post a v2 later this week with those fixed, so you don't need to waste time with those.
Thanks, Mark.
| |