| Date | Thu, 21 Apr 2022 23:00:38 +0800 | Subject | Re: [PATCH v9 05/21] cachefiles: implement on-demand read | From | JeffleXu <> |
| |
On 4/21/22 10:14 PM, David Howells wrote: > Jeffle Xu <jefflexu@linux.alibaba.com> wrote: > >> A new NETFS_SREQ_ONDEMAND flag is introduced to indicate that on-demand >> read should be done when a cache miss encountered. > > That may conflict with changes I'm making - but it's just a matter of flag > renumbering. > >> +#define CACHEFILES_IOC_CREAD _IOW(0x98, 1, int) > > I wonder if CACHEFILES_IOC_READ_COMPLETE would be a better name,
Okay, it sounds more readable. Thanks.
but apart > from that: > > Acked-by: David Howells <dhowells@redhat.com>
-- Thanks, Jeffle
|