| From | David Howells <> | Subject | Re: [PATCH v9 03/21] cachefiles: unbind cachefiles gracefully in on-demand mode | Date | Thu, 21 Apr 2022 15:02:18 +0100 |
| |
Jeffle Xu <jefflexu@linux.alibaba.com> wrote:
> + struct kref unbind_pincount;/* refcount to do daemon unbind */
Please use refcount_t or atomic_t, especially as this isn't the refcount for the structure.
> - cachefiles_daemon_unbind(cache); > - > /* clean up the control file interface */ > cache->cachefilesd = NULL; > file->private_data = NULL; > cachefiles_open = 0;
Please call cachefiles_daemon_unbind() before the cleanup.
David
|