lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v9 03/21] cachefiles: unbind cachefiles gracefully in on-demand mode
Date
Jeffle Xu <jefflexu@linux.alibaba.com> wrote:

> + struct kref unbind_pincount;/* refcount to do daemon unbind */

Please use refcount_t or atomic_t, especially as this isn't the refcount for
the structure.

> - cachefiles_daemon_unbind(cache);
> -
> /* clean up the control file interface */
> cache->cachefilesd = NULL;
> file->private_data = NULL;
> cachefiles_open = 0;

Please call cachefiles_daemon_unbind() before the cleanup.

David

\
 
 \ /
  Last update: 2022-04-21 16:04    [W:0.207 / U:3.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site