Messages in this thread | | | Subject | Re: [RFC/RFT 3/6] phy: rockchip: Support pcie v3 | From | Philipp Zabel <> | Date | Wed, 20 Apr 2022 09:29:18 +0200 |
| |
On Sa, 2022-04-16 at 15:54 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > RK3568 supports PCIe v3 using not Combphy like PCIe v2 on rk3566. > It use a dedicated pcie-phy. Add support for this. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > driver was taken from linux 5.10 based on in > https://github.com/JeffyCN/mirrors > which now has disappeared > --- [...] > + priv->p30phy = devm_reset_control_get(dev, "phy");
Please use devm_reset_control_get_exclusive() instead. It is functionally identical but makes clear that this driver requires exclusive control over the reset line.
regards Philipp
| |