lkml.org 
[lkml]   [2022]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 2/6] gpio: realtek-otto: Support reversed port layouts
On Sat, Apr 9, 2022 at 9:56 PM Sander Vanheule <sander@svanheule.net> wrote:

> + if (dev_flags & GPIO_PORTS_REVERSED) {
> + bgpio_flags = 0;
> + ctrl->port_offset_u8 = realtek_gpio_port_offset_u8_rev;
> + ctrl->port_offset_u16 = realtek_gpio_port_offset_u16_rev;
> + } else {
> + bgpio_flags = BGPIOF_BIG_ENDIAN_BYTE_ORDER;
> + ctrl->port_offset_u8 = realtek_gpio_port_offset_u8;
> + ctrl->port_offset_u16 = realtek_gpio_port_offset_u16;
> + }

Just checking: is this really a different silicon block, or is this
GPIO_PORTS_REVERSED flag passed around just a way of saying:

if (!IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) ...?

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2022-04-21 01:03    [W:0.104 / U:1.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site