Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 21 Apr 2022 01:01:37 +0200 | Subject | Re: [PATCH v1 2/6] gpio: realtek-otto: Support reversed port layouts |
| |
On Sat, Apr 9, 2022 at 9:56 PM Sander Vanheule <sander@svanheule.net> wrote:
> + if (dev_flags & GPIO_PORTS_REVERSED) { > + bgpio_flags = 0; > + ctrl->port_offset_u8 = realtek_gpio_port_offset_u8_rev; > + ctrl->port_offset_u16 = realtek_gpio_port_offset_u16_rev; > + } else { > + bgpio_flags = BGPIOF_BIG_ENDIAN_BYTE_ORDER; > + ctrl->port_offset_u8 = realtek_gpio_port_offset_u8; > + ctrl->port_offset_u16 = realtek_gpio_port_offset_u16; > + }
Just checking: is this really a different silicon block, or is this GPIO_PORTS_REVERSED flag passed around just a way of saying:
if (!IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) ...?
Yours, Linus Walleij
| |