Messages in this thread | | | Date | Tue, 19 Apr 2022 07:31:57 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver |
| |
On Fri, Apr 15, 2022 at 04:20:55PM +0200, Sven Peter wrote: > +++ b/drivers/nvme/host/apple.c > @@ -0,0 +1,1597 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Apple ANS NVM Express device driver > + * Copyright The Asahi Linux Contributors
Is that actually a valid legal entity?
> +#include <linux/io-64-nonatomic-lo-hi.h>
Does this controller still not support 64-bit MMIO accesses like the old Apple PCIe controllers or is this just a leftover?
The rest of the code looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |