Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 19 Apr 2022 11:52:15 +0200 | Subject | Re: [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver |
| |
On Tue, Apr 19, 2022 at 11:47 AM Sven Peter <sven@svenpeter.dev> wrote: > On Tue, Apr 19, 2022, at 07:31, Christoph Hellwig wrote: > > On Fri, Apr 15, 2022 at 04:20:55PM +0200, Sven Peter wrote: > >> +++ b/drivers/nvme/host/apple.c > >> @@ -0,0 +1,1597 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Apple ANS NVM Express device driver > >> + * Copyright The Asahi Linux Contributors > > > > Is that actually a valid legal entity? > > > >> +#include <linux/io-64-nonatomic-lo-hi.h> > > > > Does this controller still not support 64-bit MMIO accesses like > > the old Apple PCIe controllers or is this just a leftover? > > I just checked again and 64-bit accesses seem to work fine. > I'll remove the lo_hi_* calls and this include.
If you remove the #include, it is no longer possible to compile-test this on all 32-bit architectures, though that is probably fine as long as the Kconfig file has the right dependencies, like
depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)
I'd prefer to keep the #include here, but I don't mind the dependency if Christoph prefers it that way.
Arnd
| |