Messages in this thread | | | Date | Tue, 19 Apr 2022 14:21:39 +0200 | Subject | Re: [PATCH] sh: make !MMU iounmap an inline function | From | John Paul Adrian Glaubitz <> |
| |
Hi Geert!
On 4/19/22 11:42, Geert Uytterhoeven wrote: > Hi Rich, Sato-san, > > On Sat, Apr 16, 2022 at 12:01 AM Rob Landley <rob@landley.net> wrote: >> On 4/14/22 03:12, Vincent Whitchurch wrote: >>> The current definition of sh's !MMU iounmap makes it unusable in certain >>> kinds of code, such as this instance caught by 0day on a patch posted to >>> the mailing lists: >>> >>> In file included from include/linux/io.h:13, >>> from drivers/mtd/devices/phram.c:21: >>> drivers/mtd/devices/phram.c: In function 'register_device': >>> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do' >>> 274 | #define iounmap(addr) do { } while (0) >>> | ^~ >>> drivers/mtd/devices/phram.c:150:44: note: in expansion of macro 'iounmap' >>> 150 | cached ? memunmap(new->mtd.priv) : iounmap(new->mtd.priv); >>> | ^~~~~~~ >>> >>> Make it an inline function as it was earlier. >>> >>> Link: https://lore.kernel.org/lkml/202204131446.omJ5mC54-lkp@intel.com/ >>> Fixes: 13f1fc870dd747131 ("sh: move the ioremap implementation out of line") >>> Reported-by: kernel test robot <lkp@intel.com> >>> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> >> >> Tested-by: Rob Landley <rob@landley.net> >> >> Worked For Me. > > Can we please get any of [1], [2], [3], or [4] applied and sent > upstream, so people can stop wasting time on recreating and > resubmitting similar patches all the time?
I agree. Those patches shouldn't be sent in vain. I very much appreciate everyone sending in patches to improve Linux support for SH which is why I find it saddening that the maintainers don't find enough time to review the patches.
Adrian
-- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
| |