Messages in this thread | | | Date | Fri, 15 Apr 2022 14:21:30 -0500 | Subject | Re: [PATCH] sh: make !MMU iounmap an inline function | From | Rob Landley <> |
| |
On 4/14/22 03:12, Vincent Whitchurch wrote: > The current definition of sh's !MMU iounmap makes it unusable in certain > kinds of code, such as this instance caught by 0day on a patch posted to > the mailing lists: > > In file included from include/linux/io.h:13, > from drivers/mtd/devices/phram.c:21: > drivers/mtd/devices/phram.c: In function 'register_device': > arch/sh/include/asm/io.h:274:33: error: expected expression before 'do' > 274 | #define iounmap(addr) do { } while (0) > | ^~ > drivers/mtd/devices/phram.c:150:44: note: in expansion of macro 'iounmap' > 150 | cached ? memunmap(new->mtd.priv) : iounmap(new->mtd.priv); > | ^~~~~~~ > > Make it an inline function as it was earlier. > > Link: https://lore.kernel.org/lkml/202204131446.omJ5mC54-lkp@intel.com/ > Fixes: 13f1fc870dd747131 ("sh: move the ioremap implementation out of line") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Tested-by: Rob Landley <rob@landley.net>
Worked For Me.
Rob
| |