lkml.org 
[lkml]   [2022]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 19/20] tty: n_gsm: fix wrong behavior of gsm_carrier_raised() on debug
Date
> > From: Daniel Starke <daniel.starke@siemens.com>
> >
> > gsm_carrier_raised() returns always 1 if the kernel module parameter
> > 'debug' has its second least significant bit set. This changes the
> > behavior of the module instead of just adding some debug output.
> > Remove this 'debug' gated early out to avoid debug settings from
> > changing the program flow.
> >
> > Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
> > Cc: stable@vger.kernel.org
>
> Why is this relevant for stable backporting? It's a debugging feature
> only, and you are changing how it previously worked :(

You are right. This was a mistake on my side. Please ignore this commit
completely.

Best regards,
Daniel Starke
\
 
 \ /
  Last update: 2022-04-19 10:00    [W:0.049 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site