Messages in this thread | | | Date | Mon, 18 Apr 2022 18:07:57 +0200 | Subject | Re: [PATCH RESEND v2 8/9] arm64: dts: qcom: msm8996: Add MSM8996 Pro support | From | Krzysztof Kozlowski <> |
| |
On 16/04/2022 04:56, Yassine Oudjana wrote: > Add a new DTSI for MSM8996 Pro (MSM8996SG) with msm-id and CPU/GPU OPPs. > CBF OPPs and CPR parameters will be added to it as well once support for > CBF scaling and CPR is introduced. >
Thank you for your patch. There is something to discuss/improve.
> + > +#include "msm8996.dtsi" > + > +/* > + * MSM8996 Pro (also known as MSM8996SG) is a revision of MSM8996 with > + * different CPU, CBF and GPU frequencies as well as CPR parameters. > + */ > +/delete-node/ &cluster0_opp; > +/delete-node/ &cluster1_opp; > + > +/ { > + qcom,msm-id = <305 0x10000>; > + > + cluster0_opp: opp_table0 {
No underscores in node names. If this comes from original file, should be fixed in separate commit.
Best regards, Krzysztof
| |