Messages in this thread | | | Date | Mon, 18 Apr 2022 23:12:31 +0400 | From | Yassine Oudjana <> | Subject | Re: [PATCH RESEND v2 1/9] dt-bindings: clk: qcom: msm8996-apcc: Add CBF |
| |
On Mon, Apr 18 2022 at 18:04:08 +0200, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 16/04/2022 04:56, Yassine Oudjana wrote: >> Add CBF clock and reg. >> >> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> .../devicetree/bindings/clock/qcom,msm8996-apcc.yaml | 10 >> ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml >> b/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml >> index a20cb10636dd..325f8aef53b2 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml >> @@ -10,8 +10,8 @@ maintainers: >> - Loic Poulain <loic.poulain@linaro.org> >> >> description: | >> - Qualcomm CPU clock controller for MSM8996 CPUs, clock 0 is for >> Power cluster >> - and clock 1 is for Perf cluster. >> + Qualcomm CPU clock controller for MSM8996 CPUs, clock 0 is for >> Power cluster, >> + clock 1 is for Perf cluster, and clock 2 is for Coherent bus >> fabric (CBF). >> >> properties: >> compatible: >> @@ -19,7 +19,9 @@ properties: >> - qcom,msm8996-apcc >> >> reg: >> - maxItems: 1 >> + items: >> + - description: Cluster clock registers >> + - description: CBF clock registers > > This breaks the ABI (which might be okay or might be not, but was not > mentioned in the commit) and breaks existing DTSes. Please fix them > before this patch.
This is only documenting changes made in an earlier patch[1] this series depends on, and the DTSes are fixed in another patch[2] that is also listed as a dependency in the cover letter (both patches aren't applied yet). Shouldn't the ABI changes should be mentioned in those patches instead?
[1] https://lore.kernel.org/linux-arm-msm/20210528192541.1120703-1-konrad.dybcio@somainline.org/ [2] https://lore.kernel.org/linux-arm-msm/20210528192541.1120703-2-konrad.dybcio@somainline.org/
| |