Messages in this thread | | | Date | Tue, 8 Mar 2022 21:38:29 +0100 | Subject | Re: [PATCH 2/2] drm: ssd130x: Always apply segment remap setting | From | Javier Martinez Canillas <> |
| |
On 3/8/22 17:07, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > Currently the ssd130x driver only sets the segment remap setting when > the device tree requests it; it however does not clear the setting if > it is not requested. This leads to the setting incorrectly persisting > if the hardware is always on and has no reset GPIO wired. This might > happen when a developer is trying to find the correct settings for an > unknown module, and cause the developer to get confused because the > settings from the device tree are not consistently applied. > > Make the driver apply the segment remap setting consistently, setting > the value correctly based on the device tree setting. This also makes > this setting's behavior consistent with the other settings, which are > always applied. >
Nice catch. This is certainly much better. Thanks!
> Fixes: a61732e80867 ("drm: Add driver for Solomon SSD130x OLED displays") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > ---
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
-- Best regards,
Javier Martinez Canillas Linux Engineering Red Hat
| |