Messages in this thread | | | Date | Tue, 8 Mar 2022 21:26:47 +0100 | Subject | Re: [PATCH 1/2] drm: ssd130x: Fix COM scan direction register mask | From | Javier Martinez Canillas <> |
| |
Hello Chen-Yu,
Thanks a lot for your patch.
On 3/8/22 17:07, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The SSD130x's command to toggle COM scan direction uses bit 3 and only > bit 3 to set the direction of the scanout. The driver has an incorrect > GENMASK(3, 2), causing the setting to be set on bit 2, rendering it > ineffective. > > Fix the mask to only bit 3, so that the requested setting is applied > correctly. >
Sigh, you are correct. I thought that triple checked the datasheet when writing this but I got it wrong anyways...
> Fixes: a61732e80867 ("drm: Add driver for Solomon SSD130x OLED displays") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > ---
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
-- Best regards,
Javier Martinez Canillas Linux Engineering Red Hat
| |