lkml.org 
[lkml]   [2022]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 08/16] mm/migration: avoid unneeded nodemask_t initialization
From


On 3/4/2022 5:34 PM, Miaohe Lin wrote:
> Avoid unneeded next_pass and this_pass initialization as they're always
> set before using to save possible cpu cycles when there are plenty of
> nodes in the system.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/migrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index c84eec19072a..abb0c6715e1f 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -2378,8 +2378,8 @@ static int establish_migrate_target(int node, nodemask_t *used,
> */
> static void __set_migration_target_nodes(void)
> {
> - nodemask_t next_pass = NODE_MASK_NONE;
> - nodemask_t this_pass = NODE_MASK_NONE;
> + nodemask_t next_pass;
> + nodemask_t this_pass;
> nodemask_t used_targets = NODE_MASK_NONE;
> int node, best_distance;

LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

\
 
 \ /
  Last update: 2022-03-07 03:31    [W:0.440 / U:1.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site