lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/16] mm/migration: remove unneeded local variable page_lru
    Date
    We can use page_is_file_lru() directly to help account the isolated
    pages to simplify the code a bit as same as local variable follflags.

    Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
    ---
    mm/migrate.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    diff --git a/mm/migrate.c b/mm/migrate.c
    index bc1867a5706c..da5a81052468 100644
    --- a/mm/migrate.c
    +++ b/mm/migrate.c
    @@ -1609,7 +1609,6 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
    {
    struct vm_area_struct *vma;
    struct page *page;
    - unsigned int follflags;
    int err;

    mmap_read_lock(mm);
    @@ -1619,8 +1618,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
    goto out;

    /* FOLL_DUMP to ignore special (like zero) pages */
    - follflags = FOLL_GET | FOLL_DUMP;
    - page = follow_page(vma, addr, follflags);
    + page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP);

    err = PTR_ERR(page);
    if (IS_ERR(page))
    @@ -2033,7 +2031,6 @@ static struct page *alloc_misplaced_dst_page_thp(struct page *page,

    static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
    {
    - int page_lru;
    int nr_pages = thp_nr_pages(page);
    int order = compound_order(page);

    @@ -2060,8 +2057,7 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
    if (isolate_lru_page(page))
    return 0;

    - page_lru = page_is_file_lru(page);
    - mod_node_page_state(page_pgdat(page), NR_ISOLATED_ANON + page_lru,
    + mod_node_page_state(page_pgdat(page), NR_ISOLATED_ANON + page_is_file_lru(page),
    nr_pages);

    /*
    --
    2.23.0
    \
     
     \ /
      Last update: 2022-03-04 10:36    [W:4.222 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site