lkml.org 
[lkml]   [2022]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectdrivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:924:14: error: invalid use of undefined type 'struct cpuinfo_x86'
Hi Johannes,

First bad commit (maybe != root cause):

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 787af64d05cd528aac9ad16752d11bb1c6061bb9
commit: 68f5d3f3b6543266b29e047cfaf9842333019b4c um: add PCI over virtio emulation driver
date: 10 months ago
config: um-allyesconfig (https://download.01.org/0day-ci/archive/20220401/202204010015.xWpO2OCt-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=68f5d3f3b6543266b29e047cfaf9842333019b4c
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 68f5d3f3b6543266b29e047cfaf9842333019b4c
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from arch/x86/um/asm/processor.h:41,
from include/linux/mutex.h:19,
from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/pci.h:35,
from drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:23:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c: In function 'kfd_fill_iolink_info_for_cpu':
arch/um/include/asm/processor-generic.h:97:19: error: called object is not a function or function pointer
97 | #define cpu_data (&boot_cpu_data)
| ~^~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:921:34: note: in expansion of macro 'cpu_data'
921 | struct cpuinfo_x86 *c = &cpu_data(0);
| ^~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:924:14: error: invalid use of undefined type 'struct cpuinfo_x86'
924 | if (c->x86_vendor == X86_VENDOR_AMD)
| ^~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:924:30: error: 'X86_VENDOR_AMD' undeclared (first use in this function); did you mean 'X86_VENDOR_ANY'?
924 | if (c->x86_vendor == X86_VENDOR_AMD)
| ^~~~~~~~~~~~~~
| X86_VENDOR_ANY
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:924:30: note: each undeclared identifier is reported only once for each function it appears in


vim +924 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c

520b8fb755ccfb Felix Kuehling 2017-12-08 914
6d3d8065bb14dc Nathan Chancellor 2019-01-21 915 #ifdef CONFIG_X86_64
520b8fb755ccfb Felix Kuehling 2017-12-08 916 static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size,
520b8fb755ccfb Felix Kuehling 2017-12-08 917 uint32_t *num_entries,
520b8fb755ccfb Felix Kuehling 2017-12-08 918 struct crat_subtype_iolink *sub_type_hdr)
520b8fb755ccfb Felix Kuehling 2017-12-08 919 {
520b8fb755ccfb Felix Kuehling 2017-12-08 920 int nid;
520b8fb755ccfb Felix Kuehling 2017-12-08 921 struct cpuinfo_x86 *c = &cpu_data(0);
520b8fb755ccfb Felix Kuehling 2017-12-08 922 uint8_t link_type;
520b8fb755ccfb Felix Kuehling 2017-12-08 923
520b8fb755ccfb Felix Kuehling 2017-12-08 @924 if (c->x86_vendor == X86_VENDOR_AMD)
520b8fb755ccfb Felix Kuehling 2017-12-08 925 link_type = CRAT_IOLINK_TYPE_HYPERTRANSPORT;
520b8fb755ccfb Felix Kuehling 2017-12-08 926 else
520b8fb755ccfb Felix Kuehling 2017-12-08 927 link_type = CRAT_IOLINK_TYPE_QPI_1_1;
520b8fb755ccfb Felix Kuehling 2017-12-08 928
520b8fb755ccfb Felix Kuehling 2017-12-08 929 *num_entries = 0;
520b8fb755ccfb Felix Kuehling 2017-12-08 930
520b8fb755ccfb Felix Kuehling 2017-12-08 931 /* Create IO links from this node to other CPU nodes */
520b8fb755ccfb Felix Kuehling 2017-12-08 932 for_each_online_node(nid) {
520b8fb755ccfb Felix Kuehling 2017-12-08 933 if (nid == numa_node_id) /* node itself */
520b8fb755ccfb Felix Kuehling 2017-12-08 934 continue;
520b8fb755ccfb Felix Kuehling 2017-12-08 935
520b8fb755ccfb Felix Kuehling 2017-12-08 936 *avail_size -= sizeof(struct crat_subtype_iolink);
520b8fb755ccfb Felix Kuehling 2017-12-08 937 if (*avail_size < 0)
520b8fb755ccfb Felix Kuehling 2017-12-08 938 return -ENOMEM;
520b8fb755ccfb Felix Kuehling 2017-12-08 939
520b8fb755ccfb Felix Kuehling 2017-12-08 940 memset(sub_type_hdr, 0, sizeof(struct crat_subtype_iolink));
520b8fb755ccfb Felix Kuehling 2017-12-08 941
520b8fb755ccfb Felix Kuehling 2017-12-08 942 /* Fill in subtype header data */
520b8fb755ccfb Felix Kuehling 2017-12-08 943 sub_type_hdr->type = CRAT_SUBTYPE_IOLINK_AFFINITY;
520b8fb755ccfb Felix Kuehling 2017-12-08 944 sub_type_hdr->length = sizeof(struct crat_subtype_iolink);
520b8fb755ccfb Felix Kuehling 2017-12-08 945 sub_type_hdr->flags = CRAT_SUBTYPE_FLAGS_ENABLED;
520b8fb755ccfb Felix Kuehling 2017-12-08 946
520b8fb755ccfb Felix Kuehling 2017-12-08 947 /* Fill in IO link data */
520b8fb755ccfb Felix Kuehling 2017-12-08 948 sub_type_hdr->proximity_domain_from = numa_node_id;
520b8fb755ccfb Felix Kuehling 2017-12-08 949 sub_type_hdr->proximity_domain_to = nid;
520b8fb755ccfb Felix Kuehling 2017-12-08 950 sub_type_hdr->io_interface_type = link_type;
520b8fb755ccfb Felix Kuehling 2017-12-08 951
520b8fb755ccfb Felix Kuehling 2017-12-08 952 (*num_entries)++;
520b8fb755ccfb Felix Kuehling 2017-12-08 953 sub_type_hdr++;
520b8fb755ccfb Felix Kuehling 2017-12-08 954 }
520b8fb755ccfb Felix Kuehling 2017-12-08 955
520b8fb755ccfb Felix Kuehling 2017-12-08 956 return 0;
520b8fb755ccfb Felix Kuehling 2017-12-08 957 }
d1c234e2cd1091 Felix Kuehling 2019-01-02 958 #endif
520b8fb755ccfb Felix Kuehling 2017-12-08 959

:::::: The code at line 924 was first introduced by commit
:::::: 520b8fb755ccfb07d8d743da5753cff1fcb74b9f drm/amdkfd: Add topology support for CPUs

:::::: TO: Felix Kuehling <Felix.Kuehling@amd.com>
:::::: CC: Oded Gabbay <oded.gabbay@gmail.com>

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-03-31 18:16    [W:0.024 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site